Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency updates and changes for Python 3.11 #175

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

bensteinberg
Copy link
Contributor

@bensteinberg bensteinberg commented Feb 20, 2024

This is a first cut at changes needed to run this system on a Debian bookworm machine -- that is, with Python 3.11. I'll find the changelogs/release notes for the packages in question. One test, test-routes.test_cybersource_callback_post_purchase_request, is failing with mock.mock.InvalidSpecError: Cannot autospec attr 'act_on_cs_decision' as the patch target has already been mocked out., as

Mocks can no longer be used as the specs for other Mocks.

in mock 5.0.0 and later -- see https://mock.readthedocs.io/en/latest/changelog.html

@bensteinberg
Copy link
Contributor Author

Major version updates:

Minor and point version updates:

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.35%. Comparing base (9447920) to head (9210db7).
Report is 18 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #175      +/-   ##
===========================================
+ Coverage    95.32%   95.35%   +0.02%     
===========================================
  Files           10       10              
  Lines          813      818       +5     
===========================================
+ Hits           775      780       +5     
  Misses          38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bensteinberg bensteinberg marked this pull request as ready for review February 26, 2024 14:54
@rebeccacremona
Copy link
Collaborator

Ah! I understand why the test is objecting. Yeah, that isn't the tidiest strategy... though I'm not sure I'd say the test is "spurious", exactly, just inelegant 😄. I'll see if I can think of a better way to check the same thing.

@bensteinberg bensteinberg merged commit 964db4c into harvard-lil:develop Feb 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants